Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose schema v3.9 #2073

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

thaJeztah
Copy link
Member

This is currently just a copy of the v3.8 schema, in preparation of new features to be added in the new schema.

- Description for the changelog

* Add support for docker-compose schema v3.9

- A picture of a cute animal (not mandatory but encouraged)

This is currently just a copy of the v3.8 schema, in preparation
of new features to be added in the new schema.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@ulyssessouza @silvin-lubecki PTAL

@codecov-io
Copy link

Codecov Report

Merging #2073 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2073   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files         311      311           
  Lines       21836    21836           
=======================================
  Hits        12400    12400           
  Misses       8520     8520           
  Partials      916      916

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2073 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2073   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files         311      311           
  Lines       21836    21836           
=======================================
  Hits        12400    12400           
  Misses       8520     8520           
  Partials      916      916

@thaJeztah
Copy link
Member Author

oh; @silvin-lubecki is on PTO; @vdemeester LGTY? 🤗

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester merged commit 4a57770 into docker:master Sep 3, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Sep 3, 2019
@thaJeztah thaJeztah deleted the add_compose_schema_3.9 branch September 3, 2019 07:11
@ulgens
Copy link

ulgens commented Jun 25, 2022

This is currently just a copy of the v3.8 schema, in preparation of new features to be added in the new schema.

Why? I know it's been years but it still looks weird to add fake support for a schema version which doesn't exist. Can someone provide a link to docs for 3.9?

@thaJeztah
Copy link
Member Author

Why? I know it's been years but it still looks weird to add fake support for a schema version which doesn't exist.

It's slightly confusing, but this repository was used as a the canonical definition for the 3.x compose schema (which was designed for use with docker stack). The docker compose repository maintained a copy of the definition, and was used to provide documentation for the schemas it supported.

Unfortunately, the compose spec was created using the copy of the schema in the docker/compose repository as starting point (which was slightly behind this repository), which is why some options were not included in the initial implementation of the compose spec (e.g. compose-spec/compose-spec#214)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants