-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose schema v3.9 #2073
Conversation
This is currently just a copy of the v3.8 schema, in preparation of new features to be added in the new schema. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
=======================================
Coverage 56.78% 56.78%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12400 12400
Misses 8520 8520
Partials 916 916 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
=======================================
Coverage 56.78% 56.78%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12400 12400
Misses 8520 8520
Partials 916 916 |
oh; @silvin-lubecki is on PTO; @vdemeester LGTY? 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why? I know it's been years but it still looks weird to add fake support for a schema version which doesn't exist. Can someone provide a link to docs for 3.9? |
It's slightly confusing, but this repository was used as a the canonical definition for the 3.x compose schema (which was designed for use with Unfortunately, the compose spec was created using the copy of the schema in the docker/compose repository as starting point (which was slightly behind this repository), which is why some options were not included in the initial implementation of the compose spec (e.g. compose-spec/compose-spec#214) |
This is currently just a copy of the v3.8 schema, in preparation of new features to be added in the new schema.
- Description for the changelog
* Add support for docker-compose schema v3.9
- A picture of a cute animal (not mandatory but encouraged)